Fix for issue #111 #119
Open
Fix for issue #111 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the code to properly center the QR code when no padding is provided.
Fixes the code to properly center the QR code when no padding is provided.
|
Hi @neocotic! I recently bumped into this issue. I was wondering if this PR can be considered mergeable? Thanks for the library :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was already in place to auto center the QR code but was being blocked in the
getOffset()function by checking for the padding improperly. I added a second check to make sure padding is greater than 0 and if not to run the centering math that was already in place.