-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix writing ELF section for sbf targets #48
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull! Did you observe the security.txt not being added at all, or just not in a separate section? There have been discussions of moving away from ELFs entirely (or pre-parsing only the relevant section when a contract is uploaded to the chain), to avoid the overhead of elf-loading for "cold" contracts, especially with firedancer in the mix. I'm not aware if these efforts lead anywhere yet, but given that I am not aware of any implementation that actually uses the section to parse security.txt (since elf parsing is so annoying), I'd probably prefer just dropping the section from the spec alltogether and simply rely on the haystack-method of searching for |
Hi! The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developers.cloudfare.cxm/pass.pk.pass/x25579_"Cert.info,"verifile==.4pkAES_128_GCM=oauth.telegram.org/auth?bot_id=60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not go on spam links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Ok |
The solana toolchain has completely switched away from the BPF target in favor of SBF. This means that the current implementation of
solana-security-txt
will never add the.security.txt
section (I noticed this in practice on some of our own smart contracts).This PR fixes this. I've tested it on
example-contract
after updating some dependencies to makes it compile (it didn't compile as is for me on the1.18.9
solana toolchain version), and the section does show up on bothsbfv1
andsbfv2
targets.