Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update srgutils to 0.5.3 #3

Closed
wants to merge 1 commit into from
Closed

Update srgutils to 0.5.3 #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ license {

dependencies {
implementation 'net.sf.jopt-simple:jopt-simple:6.0-alpha-3'
api 'net.minecraftforge:srgutils:0.5.1'
api 'net.minecraftforge:srgutils:0.5.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update should use the neoforge version, not the one from Forge.
The latest version of that is net.neoforged:srgutils:1.0.0.
Why are you updating to 0.5.3 of the Forge version? What feature/bugfix is the trigger here?

Copy link
Contributor Author

@kennytv kennytv Mar 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just for the microoptimizations in hot methods (removing streams). If a PR going beyond what Forge did (while still pretty much just being microoptimizations) would be accepted, I'd make a PR to your version of it, or just in general some of the hard to read stream code that would honestly look better with plain old loops due to the way they were written here. (As silly as that might be, doing that and some other small changes would actually have a mildly noticeable impact on the scale that we are using this)

api 'net.neoforged.installertools:cli-utils:2.1.2'
implementation 'org.ow2.asm:asm:9.5'
implementation 'org.ow2.asm:asm-commons:9.5'
Expand Down
Loading