Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TransformingClassLoader in Tests and Write Data-Driven Enum Extension Tests #163

Merged
merged 7 commits into from
Jun 14, 2024

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Jun 12, 2024

Change config key from enumExtender to enumExtensions since this is still the chance to have it named according to what the setting does.
The JSON file only contains extensions to enums in a declarative manner, which means enumExtensions is a better name.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 12, 2024

  • Publish PR to GitHub Packages

Last commit published: 1e7f2c69dff6dee8426660d48274bb7434eaa616.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #163' // https://github.com/neoforged/FancyModLoader/pull/163
        url 'https://prmaven.neoforged.net/FancyModLoader/pr163'
        content {
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
            includeModule('net.neoforged.fancymodloader', 'loader')
        }
    }
}

@shartte shartte marked this pull request as ready for review June 14, 2024 09:05
@Matyrobbrt Matyrobbrt merged commit 70ec5b1 into neoforged:main Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants