[port/1.21] Fix issues relating to gameplay-enchantment support

[Shadows-of-Fire]

The switch to data enchantments has left GetEnchantmentLevelEvent and IItemExtension#getAllEnchantments inoperable due to the inability to resolve Holders, which are required to populate an ItemEnchantments instance. This PR provides the necessary RegistryLookup<Enchantment> to these contexts, retrieving it "as safely as possible".

The term "as safely as possible" means compromising between accessing magic global state and patching a ton of locations. The primary technique used to access the RegistryLookup is by retrieving it from the existing Holder.Reference objects, or whatever other context is available (such as an entity).

In two cases, there was no relevant context available, which means that the global state has to be accessed through the new CommonHooks.resolveLookup function. The cases were:

1. ItemEnchantmentsPredicate.Enchantments#matches, which only has ItemStack context, and
2. EnchantmentHelper#runIterationOnItem(ItemStack, EnchantmentHelper.EnchantmentVisitor), which does not have any access to a server or level.

All other cases use available local state to resolve the RegistryLookup.

In addition, this PR resolves a todo in ArrowItem#isInfinite, updating it to reflect current systems.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: 7d5f052def8b9197a50e61bf46504329a7aa1156.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.0.0-alpha.1.21-rc1.20240613.033616
• 📦 net.neoforged:testframework:21.0.0-alpha.1.21-rc1.20240613.033616

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1089' // https://github.com/neoforged/NeoForge/pull/1089
        url 'https://prmaven.neoforged.net/NeoForge/pr1089'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1089.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1089
cd NeoForge-pr1089
curl -L https://prmaven.neoforged.net/NeoForge/pr1089/net/neoforged/neoforge/21.0.0-alpha.1.21-rc1.20240613.033616/mdk-pr1089.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[pupnewfster]

Left some comments, it also seems like IItemStackExtension#canApplyAtEnchantingTable(Enchantment) is currently a dead method? Is it still a possible hook? If not we should probably remove it. If it is a possible hook, then we likely want to hook it back up and change it to take a Holder<Enchantment> instead of an Enchantment

We also will need to make sure in the neo docs (cc: @ChampionAsh5357 ) that we specify the behavior of certain EnchantmentHelper methods compared to how we patch things. For example: EnchantmentHelper#hasAnyEnchantments just checks about tag based enchantments and not gameplay ones (which is correct from the point of view that it is only used by the grindstone in vanilla, but naming wise might confuse people).

One other thought is do we want to be patching EnchantmentHelper#hasTag to check gameplay enchantments? The uses I see are:

• Beehive block, used to check if the stack is enchanted with an enchantment in EnchantmentTags.PREVENTS_BEE_SPAWNS_WHEN_MINING
• Decorated pot, used to check if the stack is enchanted with an enchantment in EnchantmentTags.PREVENTS_DECORATED_POT_SHATTERING
• Ice block, used to check if the stack is enchanted with an enchantment in EnchantmentTags.PREVENTS_ICE_MELTING
• Infested blocks, used to check if the stack is enchanted with an enchantment in EnchantmentTags.PREVENTS_INFESTED_SPAWNS

I believe all of those are gameplay effects, so I think it would make sense for us to patch the helper method to be able to check our gameplay only ones.

[pupnewfster]

We should probably specify the behavior in the docs that unlike what we did in older mc versions, this doesn't return true by default for if the bow has the infinity enchant.

Though thinking about it, does not defaulting it like we used to mean that it is not possible to make an arrow not be infinite regardless of the enchantments on the bow?

[Shadows-of-Fire]

It does, yeah. Delegating that full control to the ArrowItem will require updating the method to basically just be a call wrapper for EnchantmentHelper.processAmmoUse

[Shadows-of-Fire]

IItemExtension#canApplyAtEnchantingTable was reimplemented as IItemExtension#isPrimaryItemFor(Holder<Enchantment>)