Allow mods to not provide pack information #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matyrobbrt
added
enhancement
|
That's kind of pointless when they can use an unbounded range that we can include in the MDK, IMO. |
|
I would argue that even then, a quick (lowcode) mod to provide reproduction steps or whatever would still require pack information to have their resources loaded and to get rid of the warning. Not everyone uses the MDK and pack information is arguably irrelevant to normal mods that don't want to get their own special pack and just want to be hidden. |
XFactHD
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
pack.mcmetais not provided or it is missing apack_formatorsupported_formats, will fall back to a pack that is always compatible and with the title being the description