Remove glazed terracotta as farmland for DESERT plant type
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches with dead bushes, which can be placed on both uncolored/raw and stained terracotta.
Matyrobbrt
requested changes
Dec 23, 2023
tests/src/main/java/net/neoforged/neoforge/debug/block/BlockTests.java
Outdated
Show resolved
Hide resolved
tests/src/main/java/net/neoforged/neoforge/debug/block/BlockTests.java
Outdated
Show resolved
Hide resolved
Matyrobbrt
requested changes
Dec 23, 2023
tests/src/main/java/net/neoforged/neoforge/debug/block/BlockTests.java
Outdated
Show resolved
Hide resolved
Simpler code makes me happy.
Matyrobbrt
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #306 by removing glazed terracotta as acceptable farmland for the
DESERTplant type.This PR also includes a related fix to expand
DESERTplant types to be plantable on both uncolored/raw terracotta and stained terracotta, to match with the plantability of dead bushes on both. (This only really matters for modded plants, because dead bushes extendBushBlockand therefore have theirmayPlaceOnmethod called to allow placing on stained terracotta anyway.)