Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight simplification of dep replacement #164

Merged
merged 2 commits into from
May 4, 2024

Conversation

Technici4n
Copy link
Member

I'm not sure I'll continue the simplification adventure. In the meanwhile, here are a few simplifications. Essentially, it's completely safe to create the source jar TaskProvider even if it won't be used later. Meaning that the distinction between IDEs and Gradle can be partially removed.

@Technici4n Technici4n requested a review from marchermans May 3, 2024 22:29
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 3, 2024

  • Publish PR to GitHub Packages

Last commit published: 0a67336c314c07da7c8cd96127bb8f09b461504d.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #164' // https://github.com/neoforged/NeoGradle/pull/164
        url 'https://prmaven.neoforged.net/NeoGradle/pr164'
        content {
            includeModule('net.neoforged.gradle', 'utils')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'userdev')
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle', 'dsl-neoform')
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle', 'vanilla')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
        }
    }
}

@sciwhiz12 sciwhiz12 added the enhancement New feature or request label May 3, 2024
@marchermans marchermans merged commit 101ae05 into neoforged:NG_7.0 May 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants