Use unique contexts for installer library lookup #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of a constant context meant that each call to `temporaryConfiguration` resulted in the same configuration being returned. As `temporaryConfiguration` only adds the requested libraries on the first use of the configuration, any subsequent invocation with the same context, even with different dependencies as arguments, would just return the configuration from the first invocation unchanged.
Last commit published: 63a42392ab071c55ddbf7b72e3d67d1bbbd68be4. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #190' // https://github.com/neoforged/NeoGradle/pull/190
url 'https://prmaven.neoforged.net/NeoGradle/pr190'
content {
includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
includeModule('net.neoforged.gradle', 'mixin')
includeModule('net.neoforged.gradle', 'dsl-neoform')
includeModule('net.neoforged.gradle', 'dsl-common')
includeModule('net.neoforged.gradle', 'dsl-mixin')
includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
includeModule('net.neoforged.gradle', 'vanilla')
includeModule('net.neoforged.gradle', 'dsl-userdev')
includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
includeModule('net.neoforged.gradle', 'dsl-vanilla')
includeModule('net.neoforged.gradle', 'common')
includeModule('net.neoforged.gradle', 'utils')
includeModule('net.neoforged.gradle', 'platform')
includeModule('net.neoforged.gradle', 'dsl-platform')
includeModule('net.neoforged.gradle', 'neoform')
includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
includeModule('net.neoforged.gradle', 'userdev')
includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a current issue with the generation of the legacy installer profile that causes the tools used in the processor steps to not be included in the
librariessection, causing the tools to not be downloaded.The fix is to change the context used for calling
temporaryConfigurationto be unique for each given tool, rather than using a constant context.The use of a constant context meant that each call to
temporaryConfigurationresulted in the same configuration being returned. AstemporaryConfigurationonly adds the requested libraries on the first use of the configuration (as it checks if the configuration is first empty before adding the requested dependencies), any subsequent invocation with the same context, even with different dependencies as arguments, would just return the configuration from the first invocation unchanged.