-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add support for DevLogin #192
Conversation
Last commit published: 963b58710c7c9770ba0be3fbf769d59881e28ea6. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #192' // https://github.com/neoforged/NeoGradle/pull/192
url 'https://prmaven.neoforged.net/NeoGradle/pr192'
content {
includeModule('net.neoforged.gradle', 'common')
includeModule('net.neoforged.gradle', 'mixin')
includeModule('net.neoforged.gradle', 'dsl-mixin')
includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
includeModule('net.neoforged.gradle', 'test-utils')
includeModule('net.neoforged.gradle', 'dsl-neoform')
includeModule('net.neoforged.gradle', 'dsl-userdev')
includeModule('net.neoforged.gradle', 'neoform')
includeModule('net.neoforged.gradle', 'dsl-platform')
includeModule('net.neoforged.gradle', 'platform')
includeModule('net.neoforged.gradle', 'dsl-vanilla')
includeModule('net.neoforged.gradle', 'vanilla')
includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
includeModule('net.neoforged.gradle', 'dsl-common')
includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
includeModule('net.neoforged.gradle', 'utils')
includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
includeModule('net.neoforged.gradle', 'userdev')
includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
}
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it disabled by default. At least in neodev.
Is there a reason why? |
Clarified via discord. Was personal preference of @Technici4n. We decided to disable the flag on the run, this leaves the subsystem enabled, while having no effect for the user. |
dsl/common/src/main/groovy/net/neoforged/gradle/dsl/common/util/Constants.groovy
Outdated
Show resolved
Hide resolved
common/src/main/java/net/neoforged/gradle/common/CommonProjectPlugin.java
Outdated
Show resolved
Hide resolved
common/src/main/java/net/neoforged/gradle/common/CommonProjectPlugin.java
Outdated
Show resolved
Hide resolved
Addressed all comments. |
common/src/main/java/net/neoforged/gradle/common/extensions/subsystems/SubsystemsExtension.java
Show resolved
Hide resolved
common/src/main/java/net/neoforged/gradle/common/CommonProjectPlugin.java
Outdated
Show resolved
Hide resolved
Glad to see a tool I wrote to give me my skin in-dev put to real use. It may be worth exposing DevLogin's profile system via the DSL |
Update documentation. Error out when the user adds dev login to a none client run.
…abled system-wide or not.
…ile as by suggestion of covers.
56c5639
to
dc5549b
Compare
Per personal request in discord: https://discord.com/channels/313125603924639766/801175194298744902/1246148286323101838
Per personal request in discord: https://discord.com/channels/313125603924639766/1154167065519861831/1247466231435362335
TLDR:
DevLogin Support:
We now support the use of DevLogin by @covers1624.
You can use the following DSL to enable it:
runs { someRun { devLogin { enabled true } } }
By default the tool is disabled on all client runs.
Warning
If you enable the dev login tool for a none client run, you will get an error message.
Better error handling:
There is now better error handling if you do not configure mod sources in a run.
Closes:
Closes: #100