Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation of notification function #133

Merged
merged 2 commits into from
Jan 18, 2024
Merged

implementation of notification function #133

merged 2 commits into from
Jan 18, 2024

Conversation

n0n3br
Copy link
Contributor

@n0n3br n0n3br commented Jan 17, 2024

Current behavior

  • there isn't a function to add system notifications to user

Proposed changes

  • fix Notification from system #131 - create neogpt/utils/notify.py file in the project and create a function called notify which accepts 2 parameters i.e title, message to send cross platform system notification to user.

Checks

  • All commits in this Pull Request are signed and Verified by Github.

@neokd
Copy link
Owner

neokd commented Jan 18, 2024

@n0n3br thanks for your contribution. Is this contribution under the jwoc contest?

@n0n3br
Copy link
Contributor Author

n0n3br commented Jan 18, 2024

No, it's not.

@neokd
Copy link
Owner

neokd commented Jan 18, 2024 •
edited
Loading

Okkayy, thanks for the contribution.

@n0n3br
Copy link
Contributor Author

n0n3br commented Jan 18, 2024

You're welcome.

@neokd neokd merged commit af69fef into neokd:main Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification from system
2 participants
@n0n3br @neokd