Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated PDF capabilities #158

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Integrated PDF capabilities #158

merged 2 commits into from
Jan 30, 2024

Conversation

ayushmorbar
Copy link
Contributor

Current behavior

  • Now supports text and pdf file processing (txt, pdf)

Proposed changes

  • Integrated PyMuPDF for PDF parsing, allowing text extraction from PDF files.
  • Enhanced code to seamlessly handle text and PDF files in user interaction.

Checks

  • Ensured compatibility with existing file types.
  • Updated requirements.txt with PyMuPDF library version 1.23.16 for easy dependency installation
  • All commits in this Pull Request are signed and Verified by Github.

@ayushmorbar ayushmorbar mentioned this pull request Jan 30, 2024
Closed
@neokd
Copy link
Owner

neokd commented Jan 30, 2024

@ayushmorbar you can use PDFMiner Loader. Since thats common in the repo and used. Instead of adding one more dependency.

@ayushmorbar
Copy link
Contributor Author

Alright, lemme change that then.

@ayushmorbar
Copy link
Contributor Author

@ayushmorbar you can use PDFMiner Loader. Since thats common in the repo and used. Instead of adding one more dependency.

I've made the changes as asked in the code.

@neokd
Copy link
Owner

neokd commented Jan 30, 2024

Thanks for your contribution @ayushmorbar

@neokd neokd merged commit 6470948 into neokd:main Jan 30, 2024
@ayushmorbar
Copy link
Contributor Author

Appreciated 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy JWOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushmorbar @neokd