This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Fix neon build when run without arguments
#56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`neon build` did no longer build the module from the `native` sub-directory automatically. This breaking change was introduced in version 0.1.14 with commit 42726bd [1]. The problem is the ternary operator. It doesn't evaluate as expected. An empty array evaluate as `true` (same as for an `if` statement): > [] ? true : false; true Therefore an empty list of modules evaluated to `true` and the code tried to resolve their paths, which lead again to an empty array, which lead to not building anything at all. The fix is to check for the length of the array. [1]: neon-bindings@42726bd#diff-d9d9214113dea1c364abd4ba3c70be11R141
|
Ha! I overlooked your PR and already landed 788ac1a last night. But thanks so much for the PR! |
|
Wouldn't it make sense to make a new bugfix release? Without this change all applications that have a version like |
|
Yes, sorry! Pushing a build asap… |
|
OK, published 0.1.16! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neon builddid no longer build the module from thenativesub-directoryautomatically. This breaking change was introduced in version 0.1.14 with
commit 42726bd 1.
The problem is the ternary operator. It doesn't evaluate as expected. An
empty array evaluate as
true(same as for anifstatement):Therefore an empty list of modules evaluated to
trueand the code triedto resolve their paths, which lead again to an empty array, which lead
to not building anything at all.
The fix is to check for the length of the array.