test: add out of range date test case

crates/neon-runtime/src/napi/bindings/functions.rs

@@ -17,6 +17,10 @@ generate!(extern "C" {
 
     fn create_double(env: Env, value: f64, result: *mut Value) -> Status;
 
+    fn create_date(env: Env, value: f64, result: *mut Value) -> Status;
+
+    fn get_date_value(env: Env, value: Value, result: *mut f64) -> Status;
+
     fn create_object(env: Env, result: *mut Value) -> Status;
 
     fn get_value_bool(env: Env, value: Value, result: *mut bool) -> Status;
@@ -57,6 +61,7 @@ generate!(extern "C" {
     fn is_buffer(env: Env, value: Value, result: *mut bool) -> Status;
     fn is_error(env: Env, value: Value, result: *mut bool) -> Status;
     fn is_array(env: Env, value: Value, result: *mut bool) -> Status;
+    fn is_date(env: Env, value: Value, result: *mut bool) -> Status;
 
     fn get_value_string_utf8(
         env: Env,

crates/neon-runtime/src/napi/date.rs

@@ -1,17 +1,17 @@
 use std::mem::MaybeUninit;
-use nodejs_sys as napi;
-use raw::{Env, Local};
+use crate::napi::bindings as napi;
+use crate::raw::{Env, Local};
 
 pub unsafe fn new_date(env: Env, value: f64) -> Local {
     let mut local = MaybeUninit::zeroed();
-    let status = napi::napi_create_date(env, value, local.as_mut_ptr());
-    assert_eq!(status, napi::napi_status::napi_ok);
+    let status = napi::create_date(env, value, local.as_mut_ptr());
+    assert_eq!(status, napi::Status::Ok);
     local.assume_init()
 }
 
 pub unsafe fn value(env: Env, p: Local) -> f64 {
     let mut value = 0.0;
-    let status = napi::napi_get_date_value(env, p, &mut value as *mut _);
-    assert_eq!(status, napi::napi_status::napi_ok);
+    let status = napi::get_date_value(env, p, &mut value as *mut _);
+    assert_eq!(status, napi::Status::Ok);
     return value;
 }

crates/neon-runtime/src/napi/tag.rs

@@ -67,6 +67,6 @@ pub unsafe extern "C" fn is_arraybuffer(env: Env, val: Local) -> bool {
 
 pub unsafe extern "C" fn is_date(env: Env, val: Local) -> bool {
     let mut result = false;
-    assert_eq!(napi::napi_is_date(env, val, &mut result as *mut _), napi::napi_status::napi_ok);
+    assert_eq!(napi::is_date(env, val, &mut result as *mut _), napi::Status::Ok);
     result
 }

test/napi/lib/date.js

@@ -23,6 +23,11 @@ describe('JsDate', function() {
     assert.isNaN(date);
   });
 
+  it('should fail when creating out of bounds dates', function () {
+    const date = addon.create_out_of_bounds_date();
+    assert.isNaN(date);
+  });
+
   it('should get date value', function () {
     const dateValue = addon.get_date_value();
     assert.equal(dateValue, 31415);

test/napi/src/js/date.rs

@@ -43,6 +43,14 @@ pub fn create_and_get_invalid_date(mut cx: FunctionContext) -> JsResult<JsNumber
     Ok(cx.number(date))
 }
 
+pub fn create_out_of_bounds_date(mut cx: FunctionContext) -> JsResult<JsNumber> {
+    let time = 9_007_199_254_740_991.0;
+    let date = cx.date(time).value(&mut cx);
+    assert!(!cx.date(time).is_valid(&mut cx));
+    assert!(cx.date(time).value(&mut cx).is_nan());
+    Ok(cx.number(date))
+}
+
 pub fn get_date_value(mut cx: FunctionContext) -> JsResult<JsNumber> {
     let date = cx.date(31415);
     let value = date.value(&mut cx);

test/napi/src/lib.rs

@@ -154,6 +154,7 @@ fn main(mut cx: ModuleContext) -> NeonResult<()> {
     cx.export_function("check_date_is_valid", check_date_is_valid)?;
     cx.export_function("create_date_from_value", create_date_from_value)?;
     cx.export_function("create_and_get_invalid_date", create_and_get_invalid_date)?;
+    cx.export_function("create_out_of_bounds_date", create_out_of_bounds_date)?;
 
     cx.export_function("is_array", is_array)?;
     cx.export_function("is_array_buffer", is_array_buffer)?;