lock for the duration of drop

neon-bindings · May 22, 2021 · 48f4491 · 48f4491
1 parent 2974364
commit 48f4491
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/crates/neon-runtime/src/napi/tsfn.rs b/crates/neon-runtime/src/napi/tsfn.rs
@@ -179,9 +179,11 @@ impl<T: Send + 'static> ThreadsafeFunction<T> {
 
 impl<T> Drop for ThreadsafeFunction<T> {
     fn drop(&mut self) {
+        let is_finalized = self.is_finalized.lock().unwrap();
+
         // tsfn was already finalized by `Environment::CleanupHandles()` in
         // Node.js
-        if *self.is_finalized.lock().unwrap() {
+        if *is_finalized {
             return;
         }