Merge pull request #921 from neon-bindings/kv/unlink-before-copy

fix(cargo-cp-artifact): Unlink .node files before copying to flush macOS code signature cache

pkgs/cargo-cp-artifact/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cargo-cp-artifact",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "description": "Copies compiler artifacts emitted by rustc by parsing Cargo metadata",
   "main": "src/index.js",
   "files": [

pkgs/cargo-cp-artifact/src/index.js

@@ -2,9 +2,9 @@
 
 const { spawn } = require("child_process");
 const {
-  promises: { copyFile, mkdir, stat },
+  promises: { copyFile, mkdir, stat, unlink },
 } = require("fs");
-const { dirname } = require("path");
+const { dirname, extname } = require("path");
 const readline = require("readline");
 
 const { ParseError, getArtifactName, parse } = require("./args");
@@ -122,6 +122,24 @@ async function copyArtifact(filename, outputFile) {
     await mkdir(outputDir, { recursive: true });
   }
 
+  // Apple Silicon (M1, etc.) requires shared libraries to be signed. However,
+  // the macOS code signing cache isn't cleared when overwriting a file.
+  // Deleting the file before copying works around the issue.
+  //
+  // Unfortunately, this workaround is incomplete because the file must be
+  // deleted from the location it is loaded. If further steps in the user's
+  // build process copy or move the file in place, the code signing cache
+  // will not be cleared.
+  //
+  // https://github.com/neon-bindings/neon/issues/911
+  if (extname(outputFile) === ".node") {
+    try {
+      await unlink(outputFile);
+    } catch (_e) {
+      // Ignore errors; the file might not exist
+    }
+  }
+
   await copyFile(filename, outputFile);
 }
 

test/electron/package.json

@@ -13,7 +13,7 @@
   "repository": "https://github.com/electron/electron-quick-start",
   "devDependencies": {
     "@playwright/test": "^1.23.1",
-    "cargo-cp-artifact": "^0.1.6",
+    "cargo-cp-artifact": "^0.1.7",
     "electron": "^19.0.7",
     "playwright": "^1.23.1"
   }

test/napi/package.json

@@ -9,7 +9,7 @@
     "test": "mocha --v8-expose-gc --timeout 5000 --recursive lib"
   },
   "devDependencies": {
-    "cargo-cp-artifact": "^0.1.6",
+    "cargo-cp-artifact": "^0.1.7",
     "chai": "^4.3.6",
     "mocha": "^10.0.0"
   }