Avoid leaving a dangling future when handling a rejection in JsPromis…

…e::to_future
neon-bindings · Nov 27, 2023 · f8cedab · f8cedab
1 parent cd740c9
commit f8cedab
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/crates/neon/src/types_impl/promise.rs b/crates/neon/src/types_impl/promise.rs
@@ -186,7 +186,6 @@ impl JsPromise {
             + 'static,
     {
         let then = self.get::<JsFunction, _, _>(cx, "then")?;
-        let catch = self.get::<JsFunction, _, _>(cx, "catch")?;
 
         let (tx, rx) = oneshot::channel();
         let take_state = {
@@ -235,8 +234,11 @@ impl JsPromise {
             }
         })?;
 
-        then.exec(cx, Handle::new_internal(Self(self.0)), [resolve.upcast()])?;
-        catch.exec(cx, Handle::new_internal(Self(self.0)), [reject.upcast()])?;
+        then.exec(
+            cx,
+            Handle::new_internal(Self(self.0)),
+            [resolve.upcast(), reject.upcast()],
+        )?;
 
         Ok(JsFuture { rx })
     }