Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't get the Isolate from thread locals #3

Closed
dherman opened this issue Sep 24, 2015 · 0 comments
Closed

don't get the Isolate from thread locals #3

dherman opened this issue Sep 24, 2015 · 0 comments

Comments

@dherman
Copy link
Collaborator

dherman commented Sep 24, 2015

The thread-local state tracking the current Isolate is probably going to be deprecated. The Isolate should be threaded through all methods calls from parameters that have access to it. In particular, it should be chained from the FunctionCallbackInfo's info->GetIsolate() method:

call.run(|scope| {
    ...
    scope.array(...)
    scope.object(...)
    ...
})
@dherman dherman closed this as completed in fae410f Oct 7, 2015
alshdavid added a commit to alshdavid-forks/neon that referenced this issue Jun 22, 2024
@alshdavid
# This is a combination of 9 commits.
2081a98 
# This is the 1st commit message:

get_uv

# This is the commit message neon-bindings#2:

added AsyncContext and cx.spawn_async

# This is the commit message neon-bindings#3:

added async function registration

# This is the commit message neon-bindings#4:

tidy

# This is the commit message neon-bindings#5:

comments

# This is the commit message neon-bindings#6:

using futures

# This is the commit message neon-bindings#7:

using futures

# This is the commit message neon-bindings#8:

vendored libuv

# This is the commit message neon-bindings#9:

Incorrect settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dherman