Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail the build if a test fails #191

Merged
merged 4 commits into from
Mar 9, 2017
Merged

Fail the build if a test fails #191

merged 4 commits into from
Mar 9, 2017

Conversation

jedireza
Copy link
Contributor

@jedireza jedireza commented Feb 28, 2017 •
edited
Loading

This issue may be relevant: travis-ci/travis-ci#1066

@jedireza jedireza requested a review from dherman February 28, 2017 05:54
@jedireza
Copy link
Contributor Author

@dherman there's a failure with compile_tests and it looks like it's been failing for a while now (for the last month, if not longer). Should we open another issue for that or try to fix it in this PR?

Also it doesn't look like AppVeyor is running compile_tests for Rust nightly on Windows, is that something we should address here, in another issue or not worry about it?

@dherman
Copy link
Collaborator

dherman commented Mar 9, 2017

@jedireza Sorry for the delay. Let's merge this and open another issue for the compile_tests failure.

@dherman
Copy link
Collaborator

dherman commented Mar 9, 2017

r+

@dherman dherman merged commit 88f6937 into neon-bindings:master Mar 9, 2017
@jedireza jedireza deleted the red-build-if-test-fails branch March 9, 2017 21:13
@jedireza jedireza mentioned this pull request May 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman Awaiting requested review from dherman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedireza @dherman