Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More API tweaks #332

Merged
merged 7 commits into from
Jul 12, 2018
Merged

More API tweaks #332

merged 7 commits into from
Jul 12, 2018

Conversation

dherman
Copy link
Collaborator

@dherman dherman commented Jul 12, 2018

Some slight improvements to the API before publishing as 0.2:

  • Move JsResult back to neon::result
  • Rename ResultExt back to JsResultExt
  • Rename neon::value to neon::types
  • Move handles to a neon::handle module
  • Rename unwrap_or_throw() to or_throw()
  • Add downcast_or_throw() shorthand for downcast().or_throw(cx)

@dherman dherman merged commit ca17a7b into neon-bindings:master Jul 12, 2018
@dherman dherman deleted the kjv-feedback branch July 12, 2018 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dherman