Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic N-API tests #449

Merged
merged 3 commits into from
Oct 3, 2019
Merged

Basic N-API tests #449

merged 3 commits into from
Oct 3, 2019

Conversation

dherman
Copy link
Collaborator

@dherman dherman commented Oct 2, 2019

Adds N-API tests to the test suite. Currently just has one "hello world" test to show modules can be loaded, since that's all we've implemented so far.

@dherman dherman changed the title Basic N-API tests. Basic N-API tests Oct 2, 2019
@dherman dherman marked this pull request as ready for review October 2, 2019 17:01
@dherman dherman requested a review from kjvalencik October 2, 2019 17:01
@dherman dherman mentioned this pull request Oct 2, 2019
26 tasks
@dherman
Copy link
Collaborator Author

dherman commented Oct 2, 2019

Oh whoops! This fails CI for Node 8, which is expected. I'll add logic to disable the N-API tests for Node < 10.

@dherman dherman merged commit 37191e3 into master Oct 3, 2019
@dherman dherman deleted the napi-tests branch October 3, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants