Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read architecture from node-gyp correctly #491

Merged
merged 3 commits into from
May 16, 2020
Merged

Read architecture from node-gyp correctly #491

merged 3 commits into from
May 16, 2020

Commits on Feb 18, 2020

  1. Attempt to fix architecture detection 

    It was executing node-gyp configure and trying to read the arch
from the output, but was doing so by looking at a string that
printed was platform gyp was running on rather than the target
platform. node-gyp --build does output the target architecture
though, so parse it from that.
    @dbkr
    dbkr committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    700bbd6 View commit details
    Browse the repository at this point in the history

  2. Need verbose flag to build to output architecture

    @dbkr
    dbkr committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    606825b View commit details
    Browse the repository at this point in the history

  3. Put node_gyp_output back 

    That line needs to stay for the root dir / lib file
    @dbkr
    dbkr committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    fe3bdfc View commit details
    Browse the repository at this point in the history