Fix crash in DowncastError Display impl, remove String member #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Display impl for DowncastError, fmt() calls self.to_string(), which calls fmt(), which calls self.to_string(), which... causing the following to crash:
This commit also removes the String member in DowncastError, eliminating the allocation overhead on creation (which is then paid when/if the error is thrown), and removes the Error::description() impl, which has been deprecated since rust 1.42.