Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up: Lots of lint fixes #609

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Clean-up: Lots of lint fixes #609

merged 4 commits into from
Mar 12, 2021

Conversation

kjvalencik
Copy link
Member

@kjvalencik kjvalencik commented Sep 28, 2020 •
edited
Loading

This fixes most clippy warnings. A couple would be breaking changes to public APIs and are ignored.

There are also lots of breaking changes to neon-runtime, but we consider that internal.

The missing_safety_docs lint is not addressed because that will take a pretty long time to implement.

cargo clippy --no-default-features --features legacy-runtime -- -A clippy::missing_safety_doc
cargo clippy --no-default-features --features napi-experimental -- -A clippy::missing_safety_doc

After this lands, I would like to cargo fmt the entire codebase.

@kjvalencik kjvalencik changed the title Clean-up: Clippy, fmt, docs (wip) Clean-up: Clippy, fmt, docs Sep 28, 2020
@kjvalencik kjvalencik mentioned this pull request Sep 28, 2020
Merged
@goto-bus-stop goto-bus-stop changed the base branch from master to main October 8, 2020 13:41
@kjvalencik kjvalencik force-pushed the kv/cleanup branch 2 times, most recently from cc2b002 to 2e5259e Compare November 23, 2020 16:17
@kjvalencik kjvalencik marked this pull request as ready for review March 11, 2021 20:56
@kjvalencik kjvalencik changed the title (wip) Clean-up: Clippy, fmt, docs Clean-up: Lots of lint fixes Mar 11, 2021
goto-bus-stop
goto-bus-stop approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty solid, the .cast()s are very nice, cx.is_empty() feels a little weird but i guess it's fine!

dherman
dherman approved these changes Mar 12, 2021
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 🚢

@kjvalencik kjvalencik merged commit c0d72cb into main Mar 12, 2021
@kjvalencik kjvalencik deleted the kv/cleanup branch March 12, 2021 22:30
This was referenced Jun 6, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjvalencik @dherman @goto-bus-stop