Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow additional arguments to be passed to cargo build #633

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Conversation

kjvalencik
Copy link
Member

Resolves #471

Instead of adding a special case to features and needing to keep up with cargo, all arguments after a bare -- will be passed to cargo.

neon build -- --features awesome

`neon build -- --features my-feature` will pass everything after `--` to cargo
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Might be good to follow up with CLI tests for this but if there are bugs I don't expect them to be showstoppers.

@dherman dherman merged commit e91a284 into main Nov 13, 2020
@dherman dherman deleted the kv/args branch November 13, 2020 18:20
@kjvalencik kjvalencik mentioned this pull request Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: Missing --features conditional building support
3 participants