Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Windows Arm64 target #673

Closed
wants to merge 5 commits into from
Closed

Conversation

EwoutH
Copy link

@EwoutH EwoutH commented Jan 22, 2021

Adds the aarch64-pc-windows-msvc target to the build matrix of the Windows job.

@kjvalencik
Copy link
Member

@EwoutH Thanks for the contribution!

Did you encounter issues building for Windows Arm64? Our build matrix is already kind of large and if we haven't experienced a platform specific regression, we might want to hold off adding this.

@dennisameling
Copy link

Just wanted to chime in here to mention that Neon is working correctly on Windows arm64 with the N-API backend! 🚀 signalapp/ringrtc#12

EwoutH added 3 commits March 20, 2021 12:10
Adds aarch64-pc-windows-msvc target to the build matrix
Without override: true, the default pre-installed toolchain is used, which is currently 1.48 stable.
@EwoutH
Copy link
Author

EwoutH commented Mar 20, 2021

Rebased and tuned the Rust install a bit. All Arm64 (Aarch64) builds are still failing, I will investigate a bit more later this week.

matrix:
node-version: [10.x, 12.x, 14.x, 15.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, Neon follows LTS and will support Node 10 until it goes out of maintenance 4/30.

I support removing it from the build matrix, but we may want to defer until after or closer to the date.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Maybe we could go from a full factorial matrix to a more sparse configuration. Not every node version would have to be tested on every Rust toolchain and every target.

Copy link
Member

@kjvalencik kjvalencik Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to do that before adding ARM builds. We can do a smaller matrix on PRs and the full matrix on merge to main.

@kjvalencik kjvalencik closed this Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants