Use syn-mid instead of syn + "full" #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neon's use of syn is for the #[neon::main] macro, but that doesn't actually have to parse the function body to do its work. syn-mid treats the body as an opaque blob, which should be a little faster.
|
In my not-so-scientific test, this knocked off 2s building the Node-API tests (10.5s to 8.5s). Most of that savings is compiling Solid win! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neon's use of syn is for the
#[neon::main]macro, but that doesn't actually have to parse the function body to do its work. syn-mid treats the body as an opaque blob, which should be a little faster.