Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Electron test with Playwright #835

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Replace Electron test with Playwright #835

merged 1 commit into from
Dec 5, 2021

Conversation

MikuroXina
Copy link
Contributor

Resolves #834.

dherman
dherman approved these changes Dec 5, 2021
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Playwright seems like a good choice, and I have a good impression that it's well-maintained.

test/electron/main.test.js
const { test } = require("@playwright/test");

test("greeting", async () => {
const app = await electron.launch({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! I haven't used Playwright before, but this logic is very readable.

@dherman dherman merged commit 7b164b9 into neon-bindings:next/0.10 Dec 5, 2021
@MikuroXina MikuroXina deleted the fix/test branch December 5, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjvalencik kjvalencik kjvalencik approved these changes

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikuroXina @dherman @kjvalencik