Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize the Neon directory structure a bit #884

Merged
merged 6 commits into from
Apr 26, 2022
Merged

Re-organize the Neon directory structure a bit #884

merged 6 commits into from
Apr 26, 2022

Conversation

kjvalencik
Copy link
Member

This is a little more consistent with workspaces. Currently pkgs only has a single module, but I will move cargo-cp-artifact in a separate PR.

Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements! I agree with removing neon::meta::BUILD_PROFILE.

This was more relevant with the legacy backend where the build profile was significant to artifacts. Since it is no longer accurate with the
additon of Cargo custom profiles and it has neglible value, it is being removed.
@kjvalencik kjvalencik merged commit 09c04b3 into main Apr 26, 2022
@kjvalencik kjvalencik deleted the kv/re-org branch April 26, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants