safety(neon): Improve safety of JsBox on Node-API >= 8 #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjvalencik
commented
Jun 10, 2022
kjvalencik
commented
Jun 17, 2022
kjvalencik
commented
Jun 17, 2022
kjvalencik
force-pushed
the
kv/type-tag
branch
4 times, most recently
from
74b9f3e to
5bab5e5
Compare
dherman
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Looks good, and I agree with the design decision you made.
It would be great to capture the rationale you explained to me somewhere (a short RFC?). And we should add to the JsBox docs information about (lack of) interoperability between module instances. But that could be done as followup.
|
|
||
| #[cfg(feature = "napi-8")] | ||
| static MODULE_TAG: once_cell::sync::Lazy<crate::sys::TypeTag> = once_cell::sync::Lazy::new(|| { | ||
| let mut lower = [0; std::mem::size_of::<u64>()]; |
There was a problem hiding this comment.
Maybe add a comment to say we aren't using this 64 bits so for now it's just reserved for future use.
There was a problem hiding this comment.
I'll add this. FYI, we're using 64-bits and not the full 128-bits.
Generate a unique type id for the crate and tag externals
kjvalencik
force-pushed
the
kv/type-tag
branch
from
5bab5e5 to
828e070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a unique type id for the crate and tag externals. This is done at runtime instead of compile time to help with reproducible builds.
This requires that the module be built for Node-API 8+. In the future, we may want to do optional symbol loading for internal code that makes runtime decisions. That way we could provide this additional safety guarantee on newer versions of Node even if it was compiled for an older version.