Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsBigInt #963

Merged
merged 1 commit into from
Feb 24, 2023
Merged

JsBigInt #963

merged 1 commit into from
Feb 24, 2023

Conversation

kjvalencik
Copy link
Member

No description provided.

@kjvalencik kjvalencik marked this pull request as ready for review February 7, 2023 23:10
@kjvalencik kjvalencik requested a review from dherman February 7, 2023 23:10
@kjvalencik kjvalencik changed the title Draft: JsBigInt JsBigInt Feb 10, 2023
dherman
dherman requested changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the API and the code is super clean and straightforward. And my god, it's full of tests…

I left one suggestion for a name change (Error -> RangeError) and some docs suggestions.

crates/neon/src/types_impl/bigint.rs Outdated Show resolved Hide resolved
crates/neon/src/types_impl/bigint.rs Show resolved Hide resolved
crates/neon/src/types_impl/bigint.rs Outdated Show resolved Hide resolved
test/napi/src/js/bigint.rs Show resolved Hide resolved
@kjvalencik kjvalencik requested a review from dherman February 17, 2023 15:03
dherman
dherman approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'd just add the endianness formula to read_digits_le as well.

@kjvalencik @zone117x
feat(neon): JsBigInt
2fa6653 
Co-authored-by: Matthew Little <zone117x@gmail.com>
@kjvalencik kjvalencik merged commit f00b457 into main Feb 24, 2023
@kjvalencik kjvalencik deleted the kv/bigint branch February 24, 2023 17:56
@kjvalencik kjvalencik mentioned this pull request Feb 24, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjvalencik @dherman