remove JsFunction type parameter
#989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a unit test that uses the global object, so it'll have a small merge conflict with #987. |
kjvalencik
reviewed
May 30, 2023
crates/neon/src/types_impl/mod.rs
Outdated
| @@ -1173,7 +1170,7 @@ impl<CL: Object> JsFunction<CL> { | |||
| /// Calls this function as a constructor. | |||
| /// | |||
| /// **See also:** [`JsFunction::construct_with`]. | |||
| pub fn construct<'a, 'b, C: Context<'a>, AS>(&self, cx: &mut C, args: AS) -> JsResult<'a, CL> | |||
| pub fn construct<'a, 'b, C: Context<'a>, AS>(&self, cx: &mut C, args: AS) -> JsResult<'a, JsObject> | |||
There was a problem hiding this comment.
Goodbye soundness hole!
Technically it wasn't a soundness hole because Node-API also checks the type, but at least it won't unexpectedly crash.
|
I love the tests checking that constructions are still objects! ❤️ |
kjvalencik
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the list of remaining breaking changes, this PR removes the
JsFunctiontype parameter. This is safe for the following reasons:f.call(null)orf.call(17)) the primitive is replaced by an object.JsObjecttype does not assume the object inherits fromObject.prototype, so it works for any JS objects, even exotic objects likeObject.create(null), proxies, module objects, etc.