Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closure functions #45

Closed
wants to merge 2 commits into from
Closed

Closure functions #45

wants to merge 2 commits into from

Conversation

kjvalencik
Copy link
Member

Proposal to allow creating JsFunction from Rust Fn closures.

Implementation

Rendered

dherman
dherman approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a great improvement to the JsFunction API, and the implementation really helped us work out the details.. Looks great to me!

text/0000-closure-functions.md Outdated Show resolved Hide resolved
@kjvalencik @dherman
Update text/0000-closure-functions.md
c5bd3d8 
Co-authored-by: Dave Herman <david.herman@gmail.com>
@kjvalencik
Copy link
Member Author

Merged in 079dc43

@kjvalencik kjvalencik closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjvalencik @dherman