Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pageserver: secondary mode equivalent of resident size #8181

Closed
jcsp opened this issue Jun 27, 2024 · 0 comments · Fixed by #8204
Closed

pageserver: secondary mode equivalent of resident size #8181

jcsp opened this issue Jun 27, 2024 · 0 comments · Fixed by #8204
Assignees
@jcsp
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver t/on_call_followup

Comments

@jcsp
Copy link
Collaborator

jcsp commented Jun 27, 2024

When secondaries are using a lot of disk space, we can infer that from the difference between attached resident sizes and physical disk space, but it would be much easier if we could see a literal number for how much space a tenant's secondary location is using.
@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt t/on_call_followup labels Jun 27, 2024
@jcsp jcsp mentioned this issue Jun 28, 2024
Merged
5 tasks
@jcsp jcsp self-assigned this Jun 28, 2024
@jcsp jcsp closed this as completed in #8204 Jul 1, 2024
@jcsp jcsp closed this as completed in aea5cfe Jul 1, 2024
VladLazar pushed a commit that referenced this issue Jul 8, 2024
@jcsp @VladLazar
pageserver: add metric pageserver_secondary_resident_physical_size (#…
a577eb8 
…8204)

## Problem

We lack visibility of how much local disk space is used by secondary
tenant locations

Close: #8181

## Summary of changes

- Add `pageserver_secondary_resident_physical_size`, tagged by tenant
- Register & de-register label sets from SecondaryTenant
- Add+use wrappers in SecondaryDetail that update metrics when
adding+removing layers/timelines
VladLazar pushed a commit that referenced this issue Jul 8, 2024
@jcsp @VladLazar
pageserver: add metric pageserver_secondary_resident_physical_size (#…
c70a016 
…8204)

## Problem

We lack visibility of how much local disk space is used by secondary
tenant locations

Close: #8181

## Summary of changes

- Add `pageserver_secondary_resident_physical_size`, tagged by tenant
- Register & de-register label sets from SecondaryTenant
- Add+use wrappers in SecondaryDetail that update metrics when
adding+removing layers/timelines
VladLazar pushed a commit that referenced this issue Jul 8, 2024
@jcsp @VladLazar
pageserver: add metric pageserver_secondary_resident_physical_size (#…
cc843d1 
…8204)

## Problem

We lack visibility of how much local disk space is used by secondary
tenant locations

Close: #8181

## Summary of changes

- Add `pageserver_secondary_resident_physical_size`, tagged by tenant
- Register & de-register label sets from SecondaryTenant
- Add+use wrappers in SecondaryDetail that update metrics when
adding+removing layers/timelines
VladLazar pushed a commit that referenced this issue Jul 8, 2024
@jcsp @VladLazar
pageserver: add metric pageserver_secondary_resident_physical_size (#…
86c8ba2 
…8204)

## Problem

We lack visibility of how much local disk space is used by secondary
tenant locations

Close: #8181

## Summary of changes

- Add `pageserver_secondary_resident_physical_size`, tagged by tenant
- Register & de-register label sets from SecondaryTenant
- Add+use wrappers in SecondaryDetail that update metrics when
adding+removing layers/timelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsp jcsp

Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver t/on_call_followup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pageserver: add metric pageserver_secondary_resident_physical_size neondatabase/neon
1 participant
@jcsp