Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of extension build commands #10356

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

hlinnaka
Copy link
Contributor

There used to be some pg version dependencies in these extensions, but now that there isn't, follow the simpler pattern used in other extensions. No change in the produced images.

There used to be some pg version dependencies in these extensions, but
now that there isn't, follow the simpler pattern used in other
extensions. No change in the produced images.
@hlinnaka hlinnaka requested a review from a team as a code owner January 11, 2025 15:10
@hlinnaka hlinnaka requested review from knizhnik and myrrc January 11, 2025 15:10
Copy link

7282 tests run: 6916 passed, 0 failed, 366 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Postgres 15

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-x86-64

Postgres 14

Code coverage* (full report)

  • functions: 32.7% (8050 of 24640 functions)
  • lines: 47.7% (66843 of 140041 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2239879 at 2025-01-11T16:07:03.707Z :recycle:

Copy link
Contributor

@myrrc myrrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe we could pipe wget to tar xf directly? Pretty sure it would be negligible but even a minor speedup could be of use in CI.

@hlinnaka
Copy link
Contributor Author

LGTM.

Maybe we could pipe wget to tar xf directly? Pretty sure it would be negligible but even a minor speedup could be of use in CI.

Makes sense. I'm also thinking of extracting these repetitive tasks into some little helper script. For example, the hypopg download steps now look like this:

RUN wget https://github.com/HypoPG/hypopg/archive/refs/tags/1.4.1.tar.gz -O hypopg.tar.gz && \
    echo "9afe6357fd389d8d33fad81703038ce520b09275ec00153c6c89282bcdedd6bc hypopg.tar.gz" | sha256sum --check && \
    mkdir hypopg-src && cd hypopg-src && tar xzf ../hypopg.tar.gz --strip-components=1 -C .

We could encapsulate those steps into invoking a script like this:

RUN download-extension --name=hypopg \
    --tarball-url=https://github.com/HypoPG/hypopg/archive/refs/tags/1.4.1.tar.gz \
    --sha256sum="9afe6357fd389d8d33fad81703038ce520b09275ec00153c6c89282bcdedd6bc"

It's not much shorter, but it's maybe a little more clear. Extra options could be added for things like different extension version for different pg versions.

@hlinnaka hlinnaka added this pull request to the merge queue Jan 11, 2025
Merged via the queue into main with commit 8327f68 Jan 11, 2025
86 checks passed
@hlinnaka hlinnaka deleted the cleanup-compute-dockerfile branch January 11, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants