Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dblink #10358

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Enable dblink #10358

merged 1 commit into from
Jan 15, 2025

Conversation

myrrc
Copy link
Contributor

@myrrc myrrc commented Jan 11, 2025 •
edited
Loading

Update compute image to include dblink #3720

@myrrc myrrc requested a review from a team as a code owner January 11, 2025 21:10
@myrrc myrrc requested review from knizhnik and tristan957 January 11, 2025 21:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2025 •
edited
Loading

7367 tests run: 6989 passed, 0 failed, 378 skipped (full report)

Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 32.8% (8156 of 24860 functions)
  • lines: 48.0% (68301 of 142173 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
4ea1ead at 2025-01-15T16:00:34.579Z :recycle:

@seongyun-ko
Copy link

let's ship it

@seongyun-ko
Copy link

@knizhnik @tristan957 :)

@myrrc myrrc requested a review from a team as a code owner January 14, 2025 15:44
@myrrc
Copy link
Contributor Author

myrrc commented Jan 14, 2025

@seongyun-ko Currently users don't have the capability to CREATE SERVER <...> FOREIGN DATA WRAPPER postgres_fdw so fdw won't be of use. As far as I've tested, dblink is fine, though

@myrrc myrrc force-pushed the myrrc/3720-dblink branch 2 times, most recently from 7fa304c to b097f20 Compare January 15, 2025 11:57
@myrrc myrrc changed the title Enable dblink and postgres_fdw extensions Enable dblink Jan 15, 2025
@myrrc myrrc force-pushed the myrrc/3720-dblink branch from b097f20 to 4ea1ead Compare January 15, 2025 14:46
@myrrc myrrc removed request for a team and knizhnik January 15, 2025 22:29
@myrrc myrrc added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit c7429af Jan 15, 2025
84 of 89 checks passed
@myrrc myrrc deleted the myrrc/3720-dblink branch January 15, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristan957 tristan957 tristan957 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myrrc @seongyun-ko @tristan957