Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the tests for pg_anon #10382

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Remove the tests for pg_anon #10382

merged 2 commits into from
Jan 21, 2025

Conversation

a-masterov
Copy link
Contributor

Problem

We are removing the pg_anon v1 extension from Neon. So we don't need to test it anymore and can remove the code for simplicity.

Summary of changes

The code required for testing pg_anon is removed.

@a-masterov a-masterov force-pushed the amasterov/remove-anon-tests branch from 347d2dd to 6c67546 Compare January 14, 2025 13:06
@a-masterov a-masterov requested a review from a team as a code owner January 14, 2025 13:16
Copy link

github-actions bot commented Jan 14, 2025

7359 tests run: 6979 passed, 0 failed, 380 skipped (full report)


Flaky tests (8)

Postgres 17

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 33.6% (8448 of 25111 functions)
  • lines: 49.2% (70805 of 143967 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
7daf17a at 2025-01-21T16:39:25.189Z :recycle:

Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the extension itself?

@a-masterov
Copy link
Contributor Author

Should we remove the extension itself?

Let's try.

@tristan957
Copy link
Member

Are we sure that there are no users using pg_anon at the moment?

@bayandin
Copy link
Member

bayandin commented Jan 16, 2025

Are we sure that there are no users using pg_anon at the moment?

See https://github.com/neondatabase/cloud/issues/22663

@tristan957
Copy link
Member

Sounds like we just have one user left. Is someone reaching out to that user?

@a-masterov a-masterov force-pushed the amasterov/remove-anon-tests branch from d251e9f to 7daf17a Compare January 21, 2025 15:41
Copy link
Member

@tristan957 tristan957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we making changes in the compute dockerfile?

@a-masterov
Copy link
Contributor Author

Why are we making changes in the compute dockerfile?

We have to have the sources of the extension to run the tests.
As we build the extension in the compute Dockerfile, we build the new image to run the tests neon-test-extensions as a layer of the compute Dockerfile. So when we want to remove some tests of extensions, we have to remove them from the compute Dokerfile.
Here is the section of the workflow where the image is built.

@a-masterov a-masterov added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 737888e Jan 21, 2025
161 checks passed
@a-masterov a-masterov deleted the amasterov/remove-anon-tests branch January 21, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants