pagebench: add CPU profiling support #12478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8778 tests run: 8121 passed, 0 failed, 657 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
15f0498 at 2025-07-14T11:54:17.414Z :recycle: |
VladLazar
approved these changes
Jul 14, 2025
erikgrinaker
force-pushed
the
erik/pagebench-profile
branch
from
8e70f4e to
15f0498
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to an unknown Git error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The new communicator gRPC client has significantly worse Pagebench performance than a basic gRPC client. We need to find out why.
Summary of changes
Add a
pagebench --profileflag which takes a client CPU profile of the benchmark and writes a flamegraph toprofile.svg.