Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old WAL on safekeepers. #1550

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Remove old WAL on safekeepers. #1550

merged 1 commit into from
Apr 26, 2022

Conversation

arssher
Copy link
Contributor

@arssher arssher commented Apr 20, 2022

Remove when it is consumed by all of 1) pageserver (remote_consistent_lsn) 2)
safekeeper peers 3) s3 WAL offloading.

In test s3 offloading for now is mocked by directly bumping s3_wal_lsn.

ref #1403

@arssher arssher requested a review from petuhovskiy April 20, 2022 20:06
@arssher arssher force-pushed the sk-remove-wal branch 3 times, most recently from b94bc5b to bf03a9f Compare April 21, 2022 06:37
Copy link
Member

@petuhovskiy petuhovskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments on minor things

@arssher arssher force-pushed the sk-remove-wal branch 2 times, most recently from 4f9c5b9 to 4b4d946 Compare April 26, 2022 15:49
Remove when it is consumed by all of 1) pageserver (remote_consistent_lsn) 2)
safekeeper peers 3) s3 WAL offloading.

In test s3 offloading for now is mocked by directly bumping s3_wal_lsn.

ref #1403
@arssher arssher merged commit 8b9d523 into main Apr 26, 2022
@arssher arssher deleted the sk-remove-wal branch April 26, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants