Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alias to build test images simply #2464

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

SomeoneToIgnore
Copy link
Contributor

Follow-up of #2446

Yet, this makes local testing harder since all failpoints need a special flag to be used during cargo build to work locally.
rust-lang/cargo#4829 hints it's impossible to set cargo features via env vars, so there seems to be no good way to get around it with cargo config file.

fixing that, by adding a new "command" build_testing that unfolds to build --features failpoints now.

I think build_* name should reflect the name of the feature we select for #2429 (comment) idea

(a) I think that if we're using a feature flag to turn on/off testing APIs, it should be something more general than failpoints, and (b) I'm not sure what the name for that should be, or if there's a name that's typically used.

I've picked testing as a proposal, but feel free to propose yours.

Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I like the name testing. I think it makes the most sense for me to rebase #2429 on top of this and add the testing feature there (or testing-api, whatever we choose).

test_runner/README.md Outdated Show resolved Hide resolved
@SomeoneToIgnore
Copy link
Contributor Author

I think, there comes more than API with that, so just testing- seems ok, unless better options appear.

@SomeoneToIgnore SomeoneToIgnore merged commit b46c8b4 into main Sep 16, 2022
@SomeoneToIgnore SomeoneToIgnore deleted the kb/simplify-test-builds branch September 16, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants