Use LayerMap::replace in eviction #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
force-pushed
the
replace_layer
branch
from
05997c1
to
bffa290
Compare
koivunej
force-pushed
the
replace_layer
branch
from
bffa290
to
dbf10f6
Compare
koivunej
requested review from
knizhnik,
SomeoneToIgnore,
problame and
a team
and removed request for
a team and
knizhnik
koivunej
commented
Feb 6, 2023
koivunej
commented
Feb 6, 2023
|
I think this is ready to be merged, it's a quite minor changing of the new endpoint, don't see any issues arising because of it. |
This was referenced Feb 6, 2023
SomeoneToIgnore
approved these changes
Feb 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3536, to actually use the new
Debugin replacing the layers.Turns out the two paths share a lot of handling of
Replacementbut didn't unify the two (need 3).Related to #3486.