batch api for eviction #3554
Merged
batch api for eviction #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
reviewed
Feb 7, 2023
Comment on lines
+957
to
958
| self.delete_historic_layer(layer_removal_cs, Arc::clone(local_layer), &mut updates)?; | ||
| updates.insert_historic(new_remote_layer); |
There was a problem hiding this comment.
If you rebase, you should see the replace now being used here in a conflict.
koivunej
reviewed
Feb 7, 2023
| Ok(results) | ||
| } | ||
|
|
||
| async fn evict_layer_batch_impl( |
There was a problem hiding this comment.
This is no longer async right?
IMHO the layers could be kept locked as well, since the other lock is already. Also, only one batch should happen. Or perhaps there's a reason why multiple batches?
There was a problem hiding this comment.
This is no longer async right?
Right. Will remove it for now and keep using the synchronous unlink code.
IMHO the layers could be kept locked as well, since the other lock is already.Also, only one batch should happen. Or perhaps there's a reason why multiple batches?
Yeah. Both were oversights from my side, sorry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #3552 (comment)
What do you think, @koivunej ?