refactor: allow for eviction of layers in a batch #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problame
force-pushed
the
problame/batch-evict
branch
from
7899cbd
to
fdf84aa
Compare
problame
changed the title
problame
requested review from
knizhnik
and removed request for
a team and
knizhnik
koivunej
reviewed
Feb 8, 2023
koivunej
added a commit
that referenced
this pull request
Feb 8, 2023
This changes the way we compare `Arc<dyn PersistentLayer>` in Timeline's `LayerMap` not to use `Arc::ptr_eq` which has been witnessed in development of #3557 to yield wrong results. It gives wrong results because it compares fat pointers, which are `(object, vtable)` tuples for `dyn Trait` and there are no guarantees that the `vtable`s are unique. As in there were multiple vtables for `RemoteLayer` which is why the comparison failed in #3557. This is a known issue in rust, clippy warns against it and rust std might be moving to the solution which has been reproduced on this PR: compare only object pointers by "casting out" the vtable pointer.
koivunej
approved these changes
Feb 8, 2023
koivunej
reviewed
Feb 8, 2023
problame
force-pushed
the
problame/batch-evict
branch
from
fdf84aa
to
1d822c0
Compare
|
Your refactoring suggestion does work, I was wrong about the reordering. Re drop_guard: we confirmed on Slack that it isn't actually helpful here, because it's all the same future. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: allow for eviction of layers in a batch
The auto-eviction PR (#3552) operates in two phaes:
For (2), a batch API like the one added in this commit is useful.
Note that this PR requires #3558 to be merged first.
Otherwise, the tests won't pass.