[compute_ctl] Add timeout for tracing_utils::shutdown_tracing()
#3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeoneToIgnore
approved these changes
Apr 7, 2023
Test results for 92ba921:debug build: 212 tests run: 202 passed, 0 failed, 10 (full report)release build: 212 tests run: 202 passed, 0 failed, 10 (full report) |
ololobus
force-pushed
the
alexk/compute-otel-timeout
branch
from
4cd6bbc to
a6959a4
Compare
hlinnaka
approved these changes
Apr 8, 2023
lassizci
approved these changes
Apr 8, 2023
Shutting down OTEL tracing provider may hang for quite some time, see, for example: - open-telemetry/opentelemetry-rust#868 - and our problems with staging neondatabase/cloud#3707 (comment) Yet, we want computes to shut down fast enough, as we may need a new one for the same timeline ASAP. So wait no longer than 2s for the shutdown to complete, then just error out and exit the main thread. Related to neondatabase/cloud#3707
ololobus
force-pushed
the
alexk/compute-otel-timeout
branch
from
a6959a4 to
92ba921
Compare
ThomAub
added a commit
to ThomAub/tracing-opentelemetry-instrumentation-sdk
that referenced
this pull request
Jun 9, 2024
See discussion: open-telemetry/opentelemetry-rust#868 And inspiration here neondatabase/neon#3982
davidB
pushed a commit
to davidB/tracing-opentelemetry-instrumentation-sdk
that referenced
this pull request
Jun 30, 2024
See discussion: open-telemetry/opentelemetry-rust#868 And inspiration here neondatabase/neon#3982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Shutting down OTEL tracing provider may hang for quite some time, see, for example:
Yet, we want computes to shut down fast enough, as we may need a new one for the same timeline ASAP. So wait no longer than 2s for the shutdown to complete, then just error out and exit the main thread.
Issue ticket number and link
Related to neondatabase/cloud#3707
Checklist before requesting a review
Checklist before merging