Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send AppendResponse keepalive once per second #4036

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

petuhovskiy
Copy link
Member

Describe your changes

walproposer sends AppendRequest at least once per second. This patch adds a response to these requests once per second.

Issue ticket number and link

Fixes #4017

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@petuhovskiy petuhovskiy requested a review from a team as a code owner April 15, 2023 11:59
@petuhovskiy petuhovskiy requested review from arssher and removed request for a team April 15, 2023 11:59
@github-actions
Copy link

Test results for 3782fc3:


debug build: 214 tests run: 204 passed, 0 failed, 10 (full report)


release build: 214 tests run: 204 passed, 0 failed, 10 (full report)


@arssher
Copy link
Contributor

arssher commented Apr 16, 2023

Let's drop

                        if self.reply_tx.send(reply).await.is_err() {
                            return Ok(()); // chan closed, streaming terminated
                        }

in case of NoFlushAppendRequest message; we never get/send feedback in this case anyway.

Also this patch doesn't make walreceiver send KAs on its own initiative if nothing happens (which would help detect broken connection), but this is a step forward since as it should fix #4017

@petuhovskiy petuhovskiy merged commit 73f34ea into main Apr 17, 2023
@petuhovskiy petuhovskiy deleted the sk-feedback-timeout branch April 17, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send safekeeper -> compute feedback on timeout
2 participants