Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vm-informant dbname: "neondb" -> "postgres" #4046

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

sharnoff
Copy link
Member

Describe your changes

Changes the vm-informant's postgres connection string's dbname from "neondb" (which sometimes doesn't exist) to "postgres" (which hopefully should exist more often?).

Currently there are a handful of VMs in prod that aren't working with autoscaling because they don't have the "neondb" database.

The vm-informant doesn't require any database in particular; it's just connecting as cloud_admin to be able to adjust the file cache settings.

@github-actions
Copy link

Test results for 52810e4:


debug build: 214 tests run: 204 passed, 0 failed, 10 (full report)


release build: 214 tests run: 204 passed, 0 failed, 10 (full report)


@sharnoff
Copy link
Member Author

Double-checked that the API does not allow you to delete the "postgres" database, even though it does let you delete "neondb".

@sharnoff sharnoff merged commit 02b28ae into main Apr 18, 2023
@sharnoff sharnoff deleted the sharnoff/fix-vm-informant-dbname branch April 18, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants