Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_tenant_config: allow ERROR from eviction task #4074

Merged
merged 1 commit into from
Apr 25, 2023
Merged

test_tenant_config: allow ERROR from eviction task #4074

merged 1 commit into from
Apr 25, 2023

Conversation

koivunej
Copy link
Member

Should had been caught in the review.

@koivunej koivunej requested a review from problame April 25, 2023 14:46
@koivunej
Copy link
Member Author

Reproduces 100% with time.sleep(10) after creating the tenant, but can also happen on CI: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-4071/debug/4798442479/index.html#suites/4c54991a1bdef2d920f741ae5ea7d1a1/1da88b6c87ec335c/.

@koivunej koivunej changed the title test: allow nagging from eviction task test: allow ERROR from eviction task Apr 25, 2023
@koivunej koivunej enabled auto-merge (squash) April 25, 2023 14:53
@problame problame changed the title test: allow ERROR from eviction task test_tenant_config: allow ERROR from eviction task Apr 25, 2023
@koivunej koivunej mentioned this pull request Apr 25, 2023
Merged
@koivunej koivunej disabled auto-merge April 25, 2023 14:58
@koivunej koivunej enabled auto-merge (squash) April 25, 2023 14:58
@github-actions
Copy link

Test results for 8e46959:

debug build: 219 tests run: 209 passed, 0 failed, 10 (full report)

release build: 219 tests run: 209 passed, 0 failed, 10 (full report)

@problame problame mentioned this pull request Apr 25, 2023
Merged
@koivunej koivunej merged commit bfd45dd into main Apr 25, 2023
@koivunej koivunej deleted the fix_flaky_config_test branch April 25, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@problame problame problame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koivunej @problame