GitHub Workflows: Fix crane for several registries #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for 9b1a10a:debug build: 219 tests run: 209 passed, 0 failed, 10 (full report)release build: 219 tests run: 209 passed, 0 failed, 10 (full report) |
bayandin
force-pushed
the
bayandin/fix-promote-images
branch
from
c8ed541
to
069f21f
Compare
koivunej
approved these changes
Apr 25, 2023
bayandin
force-pushed
the
bayandin/fix-promote-images
branch
7 times, most recently
from
1897660
to
ae3b738
Compare
SergeyMelnikov
approved these changes
Apr 25, 2023
bayandin
force-pushed
the
bayandin/fix-promote-images
branch
4 times, most recently
from
f1cb862
to
a7394d8
Compare
bayandin
force-pushed
the
bayandin/fix-promote-images
branch
from
a7394d8
to
9b1a10a
Compare
bayandin
changed the title
zoete
reviewed
Apr 26, 2023
| EOF | ||
| echo "{\"credsStore\":\"ecr-login\"}" > /github/home/.docker/config.json | ||
|
|
||
| - name: Copy vm-compute-node images to Docker Hub |
There was a problem hiding this comment.
nit: We're not copying in this step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Follow-up fix after #4067
Fixes the following error:
https://github.com/neondatabase/neon/actions/runs/4800125634/jobs/8540963315
Eventually, I reverted back the previous approach for promoting images (login to one registry, save images to local fs, logout and login to another registry, and push images from local fs). It turns out what works for one Google project (kaniko), doesn't work for another (crane) [sigh]
Issue ticket number and link
Checklist before requesting a review
Checklist before merging