feat: log how long tenant activation takes #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
requested review from
MMeent,
problame and
arssher
and removed request for
a team
hlinnaka
approved these changes
Apr 26, 2023
problame
requested changes
Apr 26, 2023
There was a problem hiding this comment.
In addition to the comments, I think we should have a global histogram metric for the timing as well, so we can start treating tenant activation time as a (soft) pageserver SLO and alert on it.
Would love to see the metric added in this PR as well, with the observe() call right next to the info!() line you added.
Test results for 3efeccb:debug build: 219 tests run: 209 passed, 0 failed, 10 (full report)release build: 219 tests run: 209 passed, 0 failed, 10 (full report) |
|
I was hoping to get this in for the release since we have been sitting on the user-visible problem for offsite + week. I want to have something to make progress on the user-visible issue, you can follow-up with the metric for the next release. |
|
Ok, will create an issue for the metric. |
instead of using Debug impl which includes a full backtrace pointing to few lines above, let's use the naming one (strum::IntoStaticStr).
problame
approved these changes
Apr 26, 2023
problame
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds just a counter counting up from the creation to the tenant, logged after activation. Might help guide us with the investigation of #4025.