debug_tool: get page at lsn and keyspace via http api #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note, we have a similar function called |
2250 tests run: 2134 passed, 0 failed, 116 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
33a89bf at 2023-10-06T11:13:36.755Z :recycle: |
This one does not even return the actual page. So I guess it could/should be going that. EDIT: |
koivunej
force-pushed
the
remove_remote_layer_3
branch
from
d6bca0c
to
3f34d48
Compare
koivunej
changed the title
koivunej
changed the title
|
Accompanying stresser: https://gist.github.com/koivunej/d6e3d7c21dff88b429b84f1172453ab1 I don't want to develop it in tree because compilation times. |
jcsp
approved these changes
Oct 6, 2023
botched rebase: includes partitioning
partitioning is no longer used because it's split, and outside you don't need to know about the split.
koivunej
force-pushed
the
remove_remote_layer_3
branch
from
c8ece94
to
33a89bf
Compare
koivunej
added a commit
that referenced
this pull request
Oct 26, 2023
…#4938) Implement a new `struct Layer` abstraction which manages downloadness internally, requiring no LayerMap locking or rewriting to download or evict providing a property "you have a layer, you can read it". The new `struct Layer` provides ability to keep the file resident via a RAII structure for new layers which still need to be uploaded. Previous solution solved this `RemoteTimelineClient::wait_completion` which lead to bugs like #5639. Evicting or the final local deletion after garbage collection is done using Arc'd value `Drop`. With a single `struct Layer` the closed open ended `trait Layer`, `trait PersistentLayer` and `struct RemoteLayer` are removed following noting that compaction could be simplified by simply not using any of the traits in between: #4839. The new `struct Layer` is a preliminary to remove `Timeline::layer_removal_cs` documented in #4745. Preliminaries: #4936, #4937, #5013, #5014, #5022, #5033, #5044, #5058, #5059, #5061, #5074, #5103, epic #5172, #5645, #5649. Related split off: #5057, #5134.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are any layermap or layer file related problems, having a reproducable
get_page@lsneasily usable for fast debugging iteration is helpful.Split off from #4938.
Later evolved to add http apis for:
get_page@lsnat/v1/tenant/:tenant_id/timeline/:timeline_id/get?key=<hex>&lsn=<lsn string>/v1/tenant/:tenant_id/timeline/:timeline_id/keyspace?[at_lsn=<lsn string>]last_record_lsncollecting the keyspace seems to yield some ranges for which there is no key.